need to wrap ajax response in textarea
Reported by Bryan Larsen | November 19th, 2010 @ 09:29 PM | in Hobo 1.3 (Rails 3)
To support AJAX file uploads, I need to send a standard Hobo ajax response wrapped in a textarea. Rationale: http://malsup.com/jquery/form/#file-upload
Comments and changes to this ticket
-
Bryan Larsen November 19th, 2010 @ 09:38 PM
Here's a patch that adds an option to
ajax_update_response
to allow the preamble and postamble to be changed. Comments? -
Bryan Larsen January 16th, 2011 @ 04:20 PM
- Assigned user set to Domizio Demichelis
- Milestone changed from Hobo 1.1 to Hobo 1.3 (Rails 3)
- Milestone order changed from 46 to 0
-
Domizio Demichelis February 3rd, 2011 @ 02:14 PM
Thank you Tomoaki,
I applied the patch without analizing it. I fixed it in the rails3 branch.ciao
dd -
Bryan Larsen February 3rd, 2011 @ 02:53 PM
- State changed from open to resolved
Ouch -- the patch I posted was an early version, what was committed to 1.1pre was actually correct:
https://github.com/tablatom/hobo/commit/9a0315c9e232235027ff5fe7d0b...
It's annoying when the github <-> lighthouse integration breaks. If you would have seen the comment with the link to github you probably would have used cherry-pick instead of manually applying, since that's easier.
I'll try to be more careful in the future.
-
Domizio Demichelis February 3rd, 2011 @ 03:53 PM
Cherry pick probably wouldn't work because the method has been refacoried and the file moved, anyway I usually read from the actual commit when I have to patch manually.
I am wondering whether the missing update from github has something to do with the fact that you use the [#861] at the beginning of the commit. I usually add it at the end and I never had a missing update... but maybe I am just lucky though :-)
-
Bryan Larsen February 4th, 2011 @ 01:47 AM
Don't discount cherry-pick until you've tried it. It rarely blinks at a moved file with considerable changes. Doesn't always work, but it works more often than you'd expect it to.
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
People watching this ticket
Attachments
Tags
Referenced by
- 861 need to wrap ajax response in textarea I am wondering whether the missing update from github has...