flash messages don't display if content is empty
Reported by Tiago Franco | April 28th, 2009 @ 01:27 AM | in Hobo 1.0 - Final
When a user registers he is usually redirected to a login page. This page usually contains a flash message saying that an activation e-mail was sent.
Currently the login-page tag does not displays flash messages.
Please prepend <flash-messages/> to the "content-body" section of the <login-page> tag.
Comments and changes to this ticket
-
Bryan Larsen May 1st, 2009 @ 12:59 PM
- Title changed from add flash messages to login-page to flash messages don't display if content is empty
Works for me. I added this to users_controller in agility:
def login flash[:notice] = "Hello!" hobo_login end
Here's the flow, to give you a hint on where you may be losing the flash:
login-page uses simple-page simple-page uses page (removing live-search, main-nav and account-nav)
page defines content as:
<section with-flash-messages param="content"/>
with- isn't a special prefix like without- is, with-flash-messages is an attribute to section, which displays the flash-message and the content inside a div IF AND ONLY IF content IS NOT EMPTY!
I suspect you're hitting the latter condition, which is confusing, I agree.
I'm going to rename the bug, and let Tom decide whether this behaviour is a bug or a feature.
-
Tom Locke May 1st, 2009 @ 01:41 PM
Check out commit c268e3b. If I've understood correctly I think this
should fix it? -
Tiago Franco May 4th, 2009 @ 03:48 PM
Sorry for this lame comment.
How do I browse c268e3b on github?
TF
-
Bryan Larsen May 4th, 2009 @ 04:01 PM
here's the link: http://github.com/tablatom/hobo/...
Tom committed to the master tree, so you should be able to try it out just by checking out the current version. If you're still on the gem, check out http://cookbook.hobocentral.net/...
-
Bryan Larsen May 5th, 2009 @ 12:39 PM
- Tag changed from login, rapid, signup to defect, login, rapid, signup
- State changed from new to resolved
- Milestone set to Hobo 1.0 - Final
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »