Hobo rapid breaking floats on IE7
Reported by Tiago Franco | November 21st, 2010 @ 07:04 PM | in Hobo 1.0X
- see attached images
- the fixSectionGroup function on hobo-rapid.js is breaking
floats on IE7
- first image shows hobo-rapid with no changes
- second image shows hobo-rapid after removing
'div.section-group' : function() { if (Prototype.Browser.IE) Hobo.fixSectionGroup(this); }
Comments and changes to this ticket
-
Bryan Larsen November 22nd, 2010 @ 10:45 PM
Are you using any part of the clean theme? I imagine it's some sort of quick hack to get clean working on IE. I completely agree that the code should be removed, but I suspect that means I'll have to do some IE fixups in clean elsewhere. :(
-
Tiago Franco November 22nd, 2010 @ 10:54 PM
Probably I can help. Can you remember what's the code suppose to do?
Thanks,
TF -
Bryan Larsen November 22nd, 2010 @ 11:22 PM
I didn't write that code, so I have no idea what it's supposed to fix. But if you're volunteering, my plan was to run agility in IE6/7 with and without that code snippet to see what's different, and then see if we can find a pure-CSS way of fixing the problem.
-
Tiago Franco November 23rd, 2010 @ 09:32 AM
Hi,
Please see attached files. The first one is the hack working on IE. The second one is with the hack disabled.
The hack is turning section-group into tables on IE7.
I can't export the HTML with the hack - IE won't process the JS when exporting.
Any idea why this div is being turned into tables?
Let me know if you need more screenshots.
Thanks,
TF -
Bryan Larsen January 16th, 2011 @ 09:58 PM
- State changed from new to open
- Assigned user set to Bryan Larsen
- Milestone set to Hobo 1.0X
- Milestone order changed from 197920 to 0
-
Bryan Larsen June 17th, 2011 @ 02:36 PM
- Milestone order changed from 12 to 0
fixSectionGroup just caused me more problems in one of Barquin's apps. I still hesitate to remove it from Hobo 1.0 without going through the procedure I outlined on Nov 22, but at this point I feel comfortable removing it from Hobo 1.1 & Hobo 1.3 without fixing IE6.
-
Bryan Larsen July 7th, 2011 @ 07:44 PM
- State changed from open to resolved
(from [900179e8010461d15ce7fcc2d3f895dcd62efefe]) [#863 state:resolved] remove nasty old IE6 hack. https://github.com/tablatom/hobo/commit/900179e8010461d15ce7fcc2d3f...
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป