``<table-plus>`` headers are html-escaped
Reported by Tomoaki Hayasaka | September 29th, 2010 @ 12:29 AM | in Hobo 1.3 (Rails 3)
I use Hobo 1.3pre7 + Rails 3.0.
<table-plus> headers are rendered incorrectly
where
-
they are html-escaped
-
they should be placed under
table/thead/trbut are placed beforetable
Here's a fix:
diff --git a/hobo/lib/hobo/rapid/taglibs/rapid_support.dryml b/hobo/lib/hobo/rapid/taglibs/rapid_support.dryml
index 0ad5b64..2f71601 100644
--- a/hobo/lib/hobo/rapid/taglibs/rapid_support.dryml
+++ b/hobo/lib/hobo/rapid/taglibs/rapid_support.dryml
@@ -95,7 +95,7 @@ This tag is in need of a review - it's a bit funky.
scope.field_name = n == "this" ? this.member_class.try.name : n.to_s.gsub("." , "_")
scope.field_path = n
parameters.default
- end.join
+ end.join.html_safe
end
%>
</def>
Comments and changes to this ticket
-
Domizio Demichelis September 29th, 2010 @ 02:39 PM
I am busy with other stuff, so you can help me a lot if you try it with:
- end.join
- end.safe_join
if it is working I will commit the patch. Thanks.
-
Domizio Demichelis September 29th, 2010 @ 05:01 PM
- State changed from “new” to “resolved”
- Milestone set to “Hobo 1.3 (Rails 3)”
- Assigned user set to “Domizio Demichelis”
- Milestone order changed from “197899” to “0”
fixed in 5a2405121624
-
Tom Locke September 29th, 2010 @ 05:14 PM
- State changed from “resolved” to “open”
Messing about to rescue the lost Hobo 1.3 milestone...
-
Domizio Demichelis September 29th, 2010 @ 07:49 PM
- State changed from “open” to “resolved”
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Domizio Demichelis
Tom Locke