Hobo breaks form_tag from rails
Reported by Betelgeuse | July 28th, 2010 @ 11:46 AM | in Hobo 1.3 (Rails 3)
Hobo breaks form_tag helper from rails by closing the start
tag.
html looks like:
<form action="/" method="post" />
<div style="margin:0;padding:0;display:inline"><input name="authenticity_token" type="hidden"
value="jWfMwq+S3u7Sm+bBpsJJDZIbeOmlF9cXGWgkyLZU81E=" /></div>
<div>
<input name="commit" type="submit" value="Submit" />
</div>
</form>
The relevant code that breaks the thing:
[-1, 8] in /Library/Ruby/Gems/1.8/gems/hobo-1.0.0/lib/action_view_extensions/helpers/tag_helper.rb
1 module ActionView::Helpers::TagHelper
2 alias_method :tag_without_doctype, :tag
3 def tag(name, options = nil, open = false, escape = true)
=> 4 open = !scope.xmldoctype if defined?(scope)
5 tag_without_doctype(name, options, open, escape)
6 end
7 end
/Library/Ruby/Gems/1.8/gems/hobo-1.0.0/lib/action_view_extensions/helpers/tag_helper.rb:4
open = !scope.xmldoctype if defined?(scope)
(rdb:111) p open
true
(rdb:111) n
[0, 9] in /Library/Ruby/Gems/1.8/gems/hobo-1.0.0/lib/action_view_extensions/helpers/tag_helper.rb
1 module ActionView::Helpers::TagHelper
2 alias_method :tag_without_doctype, :tag
3 def tag(name, options = nil, open = false, escape = true)
4 open = !scope.xmldoctype if defined?(scope)
=> 5 tag_without_doctype(name, options, open, escape)
6 end
7 end
/Library/Ruby/Gems/1.8/gems/hobo-1.0.0/lib/action_view_extensions/helpers/tag_helper.rb:5
tag_without_doctype(name, options, open, escape)
(rdb:111) p open
false
Comments and changes to this ticket
-
Matt Jones September 14th, 2011 @ 11:04 PM
- State changed from new to open
- Milestone set to Hobo 1.3 (Rails 3)
- Milestone order changed from 197860 to 0
-
Matt Jones September 20th, 2011 @ 05:32 PM
This actually smells sorta like a Rails bug - I can't think of a good reason they're (ab)using the
tag
helper in this manner. Would have thought that an explicit, unmatched end tag herewas regarded as a pretty nasty smell...The bigger problem is that block helpers don't seem to work in 1.3.0.RC2 at all.
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป