<transition-buttons> missing merge-attrs in <transition-button>
Reported by Henry Baragar | April 12th, 2010 @ 04:45 PM | in Hobo 1.1
I have the following line of code in my application:
<transition-buttons update="requests-section"/>
which I expected to pass the "update" attribute to the <transition-button>'s, but does not.
I believe that there is a "merge-attributes" missing in the definition of <transition-buttons>. Here is a patch to correct that:
--- taglibs/rapid_lifecycles.dryml.orig 2010-03-03 21:49:39.541488023 -0500
+++ taglibs/rapid_lifecycles.dryml 2010-04-12 11:39:30.670149876 -0400
@@ -43,7 +43,7 @@
<def tag="transition-buttons">
<div merge-attrs class="transitions">
<% this.lifecycle.publishable_transitions_for(current_user).each do |t| %>
- <transition-button transition="&t"/>
+ <transition-button merge-attrs transition="&t"/>
<% end %>
</div>
-</def>
\ No newline at end of file
+</def>
Comments and changes to this ticket
-
Bryan Larsen April 12th, 2010 @ 08:20 PM
- Milestone set to “Hobo 1.1”
- Tag changed from “defect” to “enhancement, rapid”
- State changed from “new” to “open”
- Assigned user set to “Bryan Larsen”
Usually the policy is to add the merge or merge-attrs to the outermost element, in this case the "div". You'll note that the div already contains a merge-attrs. This makes sense for some attributes like "class", but obviously added "update" to a div is kind of useless. What we can do is partition the attrs into ajax and non-ajax attributes, and merge each respectively. Will that work for you?
-
Bryan Larsen April 13th, 2010 @ 05:50 PM
- State changed from “open” to “resolved”
(from [0f8de3fb7ab1ad5b6f8a76d1a4331ebe07d83f7f]) [#697 state:resolved] merge-attrs for transition-buttons http://github.com/tablatom/hobo/commit/0f8de3fb7ab1ad5b6f8a76d1a433...
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
People watching this ticket
Bryan Larsen
Tags
Referenced by
-
697
<transition-buttons> missing merge-attrs in <transition-button>
(from [0f8de3fb7ab1ad5b6f8a76d1a4331ebe07d83f7f])
[#697
s...