<table> cuts fields with dots
Reported by Ineu | December 25th, 2009 @ 05:52 PM
I have following code:
<table-plus fields='date, account.login, operator.login, body'>
.............
</table-plus>
I'm trying to change content of cells with
<*-view:>
. In my case
<date-view:>
and <body-view:>
work fine, but <account-login-view:>
and
<operator-login-view:>
don't exist. If I use
<login-view:>
, it changes content of both
account.login and operator.login columns. Dots in field names
should be replaced with '-', if I correctly understand line 122 in
rapid_core.dryml (hobo 0.9.103): <td
param="#{this_field.to_s.sub('?', '').gsub('.',
'-')}-view"><call-tag
tag="&field_tag"/></td>
But before this line
this_field already equals to "login", so there's nothing to
replace.
Comments and changes to this ticket
-
Bryan Larsen December 28th, 2009 @ 09:16 PM
Fixed that for you. To make it even more annoying, Lighthouse's help says to use "@@@", which doesn't work with DRYML. But a four space indent and backticks do work.
This is probably a duplicate of #436, and the fix isn't easy.
-
Bryan Larsen December 28th, 2009 @ 09:59 PM
OK, I take it back, it wasn't hard to fix. I think it's obviously right, too. However, this is a fairly major API change to be doing late in the Hobo 1.0 process. Comments, Matt, Tom?
-
Matt Jones December 28th, 2009 @ 10:09 PM
I can't think of any situations where the new code wouldn't work where the old code did; the original example here clearly won't work without the change.
BTW, does this also lead to a fix for #436? Probably nice to fix both if possible.
-
Bryan Larsen December 28th, 2009 @ 10:14 PM
- Tag set to defect, rapid
What I'm worried about is people that are doing this:
<table fields="account.login"> <login-view:>blah</login-view> </table>
This also fixes #436.
-
Bryan Larsen December 29th, 2009 @ 06:30 PM
- State changed from new to resolved
(from [1d8b5a9c1a2bd3e9442726a5482659d7eec223c7]) [#592 state:resolved] [#436 state:resolved] name "foos.count" view in a table or field-list "foos-count-view" instead of "count-view" http://github.com/tablatom/hobo/commit/1d8b5a9c1a2bd3e9442726a54826...
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
People watching this ticket
Attachments
Referenced by
- 592 <table> cuts fields with dots (from [1d8b5a9c1a2bd3e9442726a5482659d7eec223c7]) [#592 s...
- 436 table-plus fails to name "count" columns correctly and uniquely (from [1d8b5a9c1a2bd3e9442726a5482659d7eec223c7]) [#592 s...