Hobo Hobo → Beyond Hobo 1.0

Comments and changes to this ticket

• 

  Matt Jones December 2nd, 2009 @ 06:37 PM

  • Assigned user set to “Matt Jones”
  • State changed from “new” to “investigating”

  From the code, it looks like the changes in d7b63ab8e112f3b60a0f37d7c8a75190845f4639 caused this; can you post the associations to/from the model that's blowing up? Looks like the first association specified via 'children' in app/viewhints/model_hints.rb doesn't have a detectable reverse_reflection.

• You flagged this item as spam.
  

  Betelgeuse December 2nd, 2009 @ 07:18 PM

  I think this is the relevant association:

   27   has_many :pivots, :dependent => :destroy
   28   has_many(:foos, :through => :pivots,
   29            :class_name => 'TheNameOfClass', :source => :attribute, :order => 'name')
   30
  

  As the stack trace has name it's probably not liking the :order attribute.

• You flagged this item as spam.
  

  Betelgeuse December 2nd, 2009 @ 07:32 PM

  After I simplified this association it choked on an another that is not even listed in viewhints:

  has_one :test_thingy, :class_name => 'Thingy', :dependent => :destroy
  

• 

  Matt Jones December 2nd, 2009 @ 07:32 PM

  It's trickier than that - :order can't cause this problem. The issue is most likely on the other end of the :through from the model that's blowing up. (assuming that :foos is first in the children view_hint)

  Here's a schematic markup of a hm:t association:
  

  class Foo:
  has_many :pivots
  has_many :bars, :through => :pivots
  
  
  
  
  
  
  
  class Pivot:
  belongs_to :foo
  belongs_to :bar
  
  
  
  
  
  
  
  class Bar:
  has_many :pivots
  has_many :foos, :through => :pivots
  

  Setting :conditions or :scope on pretty much ANY of these will cause the reverse reflection for :bars to not exist.

  Non-sanitized source (I'm guessing you don't really have a model named Foo) will always help; feel free to contact me off-LH if privacy is an issue.

• You flagged this item as spam.
  

  Betelgeuse December 2nd, 2009 @ 07:37 PM

  Yeah this seems to be coming when there's no reverse association or it can't find it. In the latter case I don't have it either as I have no need for it.

• You flagged this item as spam.
  

  Betelgeuse December 2nd, 2009 @ 07:50 PM

  Of course in the latter case I do have it or it wouldn't work :)
  Any way if you need info I am around in IRC with the same nick.

• 

  Matt Jones December 3rd, 2009 @ 01:28 AM

  (from [acd8ef0e0007c943c65723ce203c19b2263e0826]) [#565] only autoset parent if it exists http://github.com/tablatom/hobo/commit/acd8ef0e0007c943c65723ce203c...

• 

  Matt Jones December 3rd, 2009 @ 01:29 AM

  If you get a chance, can you test out the above commit and see if it works?

• You flagged this item as spam.
  

  Betelgeuse December 3rd, 2009 @ 08:31 PM

  I copied the following from the commit to an initializer and it at least the generator runs.
  There's some test failures still but they might not be related to this issue. Will report here
  after investigation they could be related to this one.

  module Hobo
    class ViewHints
      setter :children,    [] do |*args|
        # Setting children also gives a default parent using the reverse association
        child_model = model.reflections[args.first].klass
        if child_model.view_hints.parent.nil? and !child_model.view_hints.parent_defined
          parent = model.reverse_reflection(args.first)
          child_model.view_hints.parent(parent.name, :undefined => true) if parent
        end
        args
      end
    end
  end
  

• 

  Owen January 10th, 2010 @ 07:20 PM

  Is this in queue?

• 

  Owen January 10th, 2010 @ 07:28 PM

  • Milestone set to “Beyond Hobo 1.0”

• You flagged this item as spam.
  

  Betelgeuse January 10th, 2010 @ 07:43 PM

  Changing this to Beyond Hobo 1.0 is weird as this is already fixed.

• 

  Owen January 10th, 2010 @ 08:21 PM

  Thanks. It was not listed as fixed. ;-)

• 

  Matt Jones January 22nd, 2010 @ 05:40 PM

  • State changed from “investigating” to “resolved”