Hobo_login calls its block before checking to see if the user is active
Reported by Matt Jones | October 29th, 2009 @ 02:28 PM | in Beyond Hobo 1.0
The 'render :action => :account_disabled unless performed?' in hobo_login means that if you're using the block attached to hobo_login to redirect incoming users, they never see the account_disabled screen. (as there's already been a redirect) Either the block should be yielded later or the account_disabled render should be more forceful (ie, clearing the render buffer).
Comments and changes to this ticket
-
Bryan Larsen October 29th, 2009 @ 10:54 PM
- State changed from “new” to “open”
- Tag changed from “bug, hobo_login” to “defect, hobo_login”
-
Matt Jones November 30th, 2009 @ 03:39 PM
- Assigned user changed from “Matt Jones” to “Bryan Larsen”
Given the discussion on #519, I'm not convinced this is exactly a bug. Maybe a note in the documentation would be sufficient to avoid others tripping over this?
-
Bryan Larsen December 1st, 2009 @ 08:05 PM
- Tag changed from “defect, hobo_login” to “defect, documentation, hobo_login”
I took a look at this while looking at #514, and I agree with your comment. It's kind of inconsistent -- if you're logged in, it doesn't call the block, but if you log in with an invalid user, it does.
-
Bryan Larsen January 30th, 2010 @ 04:01 PM
- Tag changed from “defect, documentation, hobo_login” to “documentation, hobo_login”
-
Tom Locke February 5th, 2010 @ 10:35 PM
- Milestone changed from “Hobo 1.0 - Final” to “Beyond Hobo 1.0”
-
Bryan Larsen February 19th, 2010 @ 07:13 PM
- Tag changed from “documentation, hobo_login” to “doc, hobo_login”
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
Bryan Larsen
Matt Jones
Tom Locke