Hobo Hobo → Hobo 1.0 - Final

Comments and changes to this ticket

• 

  Tom Locke May 1st, 2009 @ 09:32 AM

  • State changed from “new” to “open”

• You flagged this item as spam.
  

  Marcelo Giorgi June 23rd, 2009 @ 01:00 AM

  I've commit a fix for it on my branch 415_visiting_sign-up_page_when_logged_in_gives_a_permission_denied_error (of my fork git://github.com/mgiorgi/hobo.git). A patch is attached here if it is easier for you to see that way.

  The fix that I committed, defines a new method hobo_signup, which redirects the user to :back (or homepage in case there is no back) or render default implementation of signup's page otherwise.

  • 0001--415-Fix-for-Visiting-sign-up-page-when-logged-in-gi.patch 1.4 KB
• 

  Tom Locke June 23rd, 2009 @ 02:01 PM

  Looks good. I'm thinking maybe a small change like this

  def hobo_signup(&b)
    if logged_in?
      redirect_back_or_default(home_page) 
    else
      creator_page_action(:signup, &b)
    end
  end
  

  would be clearer? It took me a minute to figure out why the unless_performed? was needed. Or did I miss something?

  Also, the :signup symbol needs to be taken out of the list in available_auto_actions_with_user_actions, otherwise the 'automatic' signup method gets generated and then just overwritten.

• You flagged this item as spam.
  

  Marcelo Giorgi June 23rd, 2009 @ 02:40 PM

  I've pushed the corrections (to the same branch & attached a patch with a corrected version) that you mentioned.

  You're right, its clearer this way (At first, I thought to implement it as you mentioned. But I changed later because seemed more hobo's style (looking to other methods) the option that I picked up :P).

  • 0001--415-Fix-for-Visiting-sign-up-page-when-logged-in-gi.patch 1.7 KB
• 

  Bryan Larsen October 29th, 2009 @ 11:05 PM

  • State changed from “open” to “resolved”