Hobo Hobo → Hobo 1.0 - Final

Comments and changes to this ticket

• 

  Tom Locke March 12th, 2009 @ 10:54 AM

  • Milestone set to “Hobo 1.0 - Final”
  • State changed from “new” to “open”

• You flagged this item as spam.
  

  Marcelo Giorgi June 22nd, 2009 @ 07:58 PM

  • Tag changed from “signup, validation” to “defect, signup, validation”

  I've made a fix for it on my fork git://github.com/mgiorgi/hobo.git and on my branch: 379_multiple_warning_messages_on_signup_validation

  I've also attached a patch here.

  Basically, the uniqueness of email_address was being checked twice: 1) with the :unique keyword; 2) AND with ':login => true' statement. So, I've just leave the latter.

  • 0001--379-Fix-for-multiple-warning-messages-on-signup-va.patch 942 Bytes
• 

  Bryan Larsen June 23rd, 2009 @ 04:58 PM

  I went to check that your fix didn't remove the :unique => true from schema.rb, but it looks like it was never there in the first place. validates_uniqueness_of is nice, but it's racy -- you also have to include the check in the database. This would be a separate bug, though.

• You flagged this item as spam.
  

  Marcelo Giorgi June 23rd, 2009 @ 06:06 PM

  Sorry, maybe I didn't explain the problem clearly.

  But, As I understand, the issue is that both: :unique AND :login parameters check for uniqueness. That's why the message is displayed twice. So I remove the :unique validation, assuming :login would still check for uniqueness.

  In particular my fix is just replacing this line:

   email_address :email_address, :unique, :login => true
  

  Instead of this one:
  @@@ ruby2 email_address :email_address, :login => true

  
  So, as far as I understand schema.rb is not relevant to this issue, isn't it?
  
  
  
  
  
  
  
  Please tell me, If I am wrong...
  

• 

  Tom Locke June 23rd, 2009 @ 07:30 PM

  You're fix is fine Marcelo, Bryan is just pointing out that there's another related issue, which we'll put on another ticket. Let me do that right now...

• 

  Bryan Larsen November 25th, 2009 @ 01:52 PM

  • State changed from “open” to “resolved”

  This bus has been resolved for a long time.