template_enviroment.rb: _output() choking on nil input
Reported by delineate | May 8th, 2008 @ 03:09 PM | in Hobo 0.8
I'm just trying to view standard pages of my models.
See attached stack trace.
Seems a nil is getting passed to concat in _output() from I have no
idea where. Perhaps nil isn't supposed to be passed in, but the
following one-liner patch seems to fix it for me.
Index: lib/hobo/dryml/template_environment.rb
--- lib/hobo/dryml/template_environment.rb (revision 1) +++ lib/hobo/dryml/template_environment.rb (working copy) @@ -212,7 +212,7 @@
def _output(s)
- @_erb_output.concat(s)
- @_erb_output.concat(s.nil? ? '' : s) end
Comments and changes to this ticket
-
Tom Locke July 29th, 2008 @ 10:42 AM
- Tag cleared.
That code is very much a hot-spot. I'd rather avoid an extra test on every output. Do you have steps to replicate this? Could well be fixed by now.
Sorry for slow response!
-
Tom Locke July 29th, 2008 @ 11:11 AM
- State changed from “new” to “investigating”
-
Tom Locke August 5th, 2008 @ 11:38 AM
- Tag set to “defect, dryml”
- Milestone set to “Hobo 0.8”
-
Tom Locke August 20th, 2008 @ 03:46 PM
- State changed from “investigating” to “wontfix”
Closing this as I believe this is not a bug in the current code.
Thanks for reporting this anyway.
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
Tom Locke