Hobo::Permissions::Associations::HasManyThroughAssociations::create! defined twice.
Reported by Bryan Larsen | November 17th, 2009 @ 01:08 PM | in Hobo 1.0 - Final
Comments and changes to this ticket
-
Bryan Larsen November 17th, 2009 @ 01:12 PM
- State changed from “new” to “open”
- Tag set to “associations, defect, model, permissions”
- Milestone set to “Hobo 1.0 - Final”
- Assigned user set to “Bryan Larsen”
As Iain mentioned in his comment:
Unless there is supposed to be two "create!" methods, I believe the second
one should be "create".The code is the same for both with the exception that the second uses
klass.user_create whereas the first uses klass.user_create! (which is why
I think that the first should be the one with the "!" in it's name.http://github.com/iainbeeston/hobo/commit/6dcd587d94b6ad8ae731acee1...
If it was the first definition that was wrong, this would be a seemless change since as the code stands now, the second definition of create! overrides the first. But it's the second, so this is a breaking change for anybody who depends on the wrong behaviour of create!
-
Bryan Larsen November 17th, 2009 @ 01:41 PM
- State changed from “open” to “resolved”
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
Bryan Larsen